-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Midi Handshake #365
Open
greengrooves
wants to merge
41
commits into
westlicht:master
Choose a base branch
from
jackpf:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Midi Handshake #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User settings (brightness + screensaver)
Refactored colours
Unfilled footer
* Wake mode * Fix * Properly consume screensaver events * Consume encoder properly * Dont consume encoder when screen saved
* Shapes improvements * Ported changes * Extra shapes * Remove printlns * Remove printlns
* Send midi program change messages * Remove debug statements * Default send on channel 0 * Working presend * Add always sync option * Refactor * Refactor * Refactor
* Improvement docs * Add midi improvements * Refactor
* Malekko integration * Add todos * Use channel 0 * Program saves * Midi integration setting * Refactor * Midi program offset setting * Increment project version * Revert "Increment project version" This reverts commit dd1fe66. * Update project version comment * Dont send pattern changes when snapshot mode is activated * Send program change message when midi program offset setting is updated
* Handle program change receives * Only handle if setting enabled * Handle program number overflow * Fix
* Send pattern changes in song mode * Refactor * Refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hallo,
I have litlle strange question.
I try to use my Westlicht Performer with your new implemented Program changes with an Expert Sleepers Select Bus Module. I try to send the Program Change from the Performer over the Select Bus Module to change Presets together with Varigate and Voltageblock wich only respond to Select Bus messages. The Problem is that the Malekko stuff need a handshake message first to read the program change. Would it be possible to implement this in the Program Change Message ? The Voltageblock needs a Control Message on Ch1 Data 16 Velocity64 to react to the Program Changes